[libcxx] Add local %T substitution #160026
Conversation
Created using spr 1.3.6
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesThis patch adds a %T substitution directly into the libc++ test format. Full diff: https://github.com/llvm/llvm-project/pull/160026.diff 1 Files Affected:
diff --git a/libcxx/utils/libcxx/test/format.py b/libcxx/utils/libcxx/test/format.py
index 5765afec399cf..c9dffd1bb7971 100644
--- a/libcxx/utils/libcxx/test/format.py
+++ b/libcxx/utils/libcxx/test/format.py
@@ -92,6 +92,7 @@ def parseScript(test, preamble):
# errors, which doesn't make sense for clang-verify tests because we may want to check
# for specific warning diagnostics.
_checkBaseSubstitutions(substitutions)
+ substitutions.append(("%T", tmpDir))
substitutions.append(
("%{build}", "%{cxx} %s %{flags} %{compile_flags} %{link_flags} -o %t.exe")
)
|
|
I'm going to land this given all the CI is passing (minus the flaky arm bots) and that it is pretty trivial. If there is any postcommit followup needed, please let me know and I'll address any comments there. I want to get this in reasonably soon to ensure we don't backslide on having |
boomanaiden154
deleted the
users/boomanaiden154/libcxx-add-local-t-substitution
branch
This patch adds a %T substitution directly into the libc++ test format. This ensures that the libc++ test format will continue to work when we remove support for %T in llvm lit. Reviewers: #reviewers-libcxx, ldionne, philnik777 Pull Request: llvm/llvm-project#160026
| # errors, which doesn't make sense for clang-verify tests because we may want to check | ||
| # for specific warning diagnostics. | ||
| _checkBaseSubstitutions(substitutions) | ||
| substitutions.append(("%T", tmpDir)) |
There was a problem hiding this comment.
I would suggest introducing this as %{temp} and documenting it officially as a substitution added by the libc++ testing format instead. Once %T is removed in Lit, this substitution will become seemingly random for anybody who isn't familiar with the current %T substitution provided by Lit.
This patch adds a %T substitution directly into the libc++ test format. This ensures that the libc++ test format will continue to work when we remove support for %T in llvm lit. Reviewers: #reviewers-libcxx, ldionne, philnik777 Pull Request: llvm#160026
This patch adds a %T substitution directly into the libc++ test format.
This ensures that the libc++ test format will continue to work when we
remove support for %T in llvm lit.